Project

General

Profile

Actions

Defect #811

closed

In _reply.html.erb, show_detail method undefined

Added by Fahrzin Hemmati almost 10 years ago. Updated over 9 years ago.

Status:
終了(Closed)
Priority:
通常(Normal)
Assignee:
Target version:
Start date:
08/05/2011
Due date:
% Done:

100%

Estimated time:

Description

On a default install of redmine_code_review 0.4.3, on ChiliProject 2.1.1:

1. Create a code review on a file diff on any line.
2. Refresh the page and click on the code review to view it
3. A 500 page shows up with "MethodError" and "show_detail" undefined.

The problem is in app/views/code_review/_reply.html.erb:26 at

<%= show_detail(detail) %>

This is related to this change by chiliproject:

https://www.chiliproject.org/issues/539

Could redmine_code_review be updated to use render_detail appropriately? I can't replace show_detail with render_detail directly, nor do I know rails well enough to try much beyond '@journal.render_detail' and '@reply.render_detail'.

Actions #1

Updated by Haru Iida almost 10 years ago

  • Project changed from r-labs to Code Review
  • Status changed from 新規(New) to 担当(Assigned)
  • Assignee set to Haru Iida
Actions #2

Updated by Haru Iida almost 10 years ago

Fahrzin Hemmati wrote:

Could redmine_code_review be updated to use render_detail appropriately? I can't replace show_detail with render_detail directly, nor do I know rails well enough to try much beyond '@journal.render_detail' and '@reply.render_detail'.

I think Redmine hasn't render_detail. So I can't change the code. Sorry.

Actions #3

Updated by Fahrzin Hemmati almost 10 years ago

What is the code that you would use in that template? You could put it behind an if statement that checks for render_detail so this would be compatible with both redmine and chiliproject.

Actions #4

Updated by Haru Iida over 9 years ago

  • Status changed from 担当(Assigned) to 終了(Closed)
  • Target version set to 0.4.6
  • % Done changed from 0 to 100

Fixed by Andreas Schuh.

Actions

Also available in: Atom PDF