Project

General

Profile

Actions

Defect #1336

closed

Internal error when a user is deleted in Redmine

Added by Olivier Houdas over 7 years ago. Updated over 7 years ago.

Status:
終了(Closed)
Priority:
通常(Normal)
Target version:
Start date:
06/27/2014
Due date:
% Done:

100%

Estimated time:

Description

Steps :
  1. Activate Worktime on a project
  2. Make sure user "X" is listed in the list of members, displayed in the worktime tab
  3. Delete that user in Redmine admin (not simply locked, but deleted)
  4. Display the Work time tab again on the project
    Result : Internal error
    Started GET "/redmine/work_time/show/geoconcept" for 192.168.9.13 at 2014-06-26 15:48:47 +0200
    Processing by WorkTimeController#show as HTML
      Parameters: {"id"=>"geoconcept"}
      Current user: admin (id=1)
    Completed 500 Internal Server Error in 2136.2ms
    
    NoMethodError (undefined method `active?' for nil:NilClass):
      plugins/redmine_work_time/app/controllers/work_time_controller.rb:638:in `block in member_add_del_check'
    
    

Fix suggestion:
Add a test on the user object in the loop (see patch attached)
This is not perfect (deleted users remain in the wt_members_order table), but at least it avoids the internal error.


Files

Actions

Also available in: Atom PDF