Project

General

Profile

Defect #708

pencil icon does not appear in diff view

Added by Haru Iida over 8 years ago. Updated over 8 years ago.

Status:
終了(Closed)
Priority:
通常(Normal)
Assignee:
Target version:
Start date:
04/05/2011
Due date:
% Done:

100%

Estimated time:

Description

Hello,

I've just installed the code-review plugin on Redmine 1.1.2 running on Debian Wheezy Testing with Passenger/MySQL.
I'm using it with a git repository.
I can create code-review related bugs linked to the certain revision of the code.

But the most important part of the plugin does not work. When I'm viewing diffs, the small icons do not appear on the left side, so I cannot annotate the diffs with reviews.

Do yuo know the solution?

Best regards

SZABÓ Gergely
Budapest, Hungary


Files

diffs.png (15.7 KB) diffs.png Haru Iida, 04/05/2011 11:26 PM
diff.png (10.2 KB) diff.png Haru Iida, 04/05/2011 11:26 PM
no_pencil.png (8.62 KB) no_pencil.png vincent auroch, 04/11/2011 11:10 PM

Associated revisions

Revision c2bb9188 (diff)
Added by Haru Iida over 8 years ago

fixes #708. pencil icon does not appear in diff view

History

#1

Updated by Haru Iida over 8 years ago

But the most important part of the plugin does not work. When I'm viewing diffs, the small icons do not appear on the left side, so I cannot annotate the diffs with reviews.

If you click "View differences", pencil icon does not appears.

If you click "diff" at right side of file name, you will see pencil icons.

Thanks.

#2

Updated by Gergely Szabó over 8 years ago

No, I don't see pencil icons, even if I click (diff) at right side of file name.
Arigato
Gergely

#3

Updated by vincent auroch over 8 years ago

Hello

I can confirm the same behavior, running a freshiling installed redmine (v1.0.1)

  • Pencils does not appear when making diff
  • Selecting "Code review" tab leads to a white page : Internal error

An error occurred on the page you were trying to access.
If you continue to experience problems please contact your redMine administrator for assistance.

Let me know if you would like a special access to a test project to see what could be wrong.

Vincent

#4

Updated by Haru Iida over 8 years ago

vincent auroch は書きました:

  • Pencils does not appear when making diff
  • Selecting "Code review" tab leads to a white page : Internal error

I want to see a stack trace of internal error. You can find it in production.log.

And let me know what version of code review plugin you use.

#5

Updated by Haru Iida over 8 years ago

Hi Gergely Szabó

No, I don't see pencil icons, even if I click (diff) at right side of file name.
Arigato
Gergely

hmm. Can you try my new code?
https://bitbucket.org/haru_iida/redmine_code_review/get/tip.zip

#6

Updated by vincent auroch over 8 years ago

Hello,

  • About issue Selecting "Code review" tab leads to a white page : Internal error

This was dues to a wrong name given to the pluggin when extracting your package into /vendor/pluggin. Your redmine install tutorial shall be updated to make sure user will give the right plugin name (required : redmine_code_review)

  • Still investigating the second issue (missing pensil).

Vincent

#7

Updated by vincent auroch over 8 years ago

I just add a quick look inside the log file when making the "diff" for a revision. I'm not notice anything special.

Log file content :

Processing RepositoriesController#diff (for 88.182.42.119 at 2011-04-11 14:06:40) [GET]
Parameters: {"rev"=>"f0428cd5c84664b240d5b2c45426d061ad34fa0d", "action"=>"diff", "id"=>"safboot", "path"=>["what's new.txt"], "controller"=>"repositories"}
Rendering template within layouts/base
Rendering repositories/diff
Completed in 299ms (View: 231, DB: 5) | 200 OK [http://intranet.seasidetech.net/redmine/projects/safboot/repository/revisions/f0428cd5c84664b240d5b2c45426d061ad34fa0d/diff/what's new.txt]

Processing CodeReviewController#update_diff_view (for 88.182.42.119 at 2011-04-11 14:06:40) [GET]
Parameters: {"rev"=>"f0428cd5c84664b240d5b2c45426d061ad34fa0d", "rev_to"=>"", "action"=>"update_diff_view", "id"=>"safboot", "review_id"=>"", "path"=>"/what's new.txt", "action_type"=>"diff", "controller"=>"code_review"}
Completed in 38ms (View: 13, DB: 2) | 200 OK [http://intranet.seasidetech.net/redmine/code_review/update_diff_view/safboot?rev=f0428cd5c84664b240d5b2c45426d061ad34fa0d&path=%2Fwhat%27s%20new.txt&review_id=&action_type=diff&rev_to=]

What I can see : the diff window without pencil :

#8

Updated by vincent auroch over 8 years ago

One question : is there a way to re-start the redmine pluggin install to make sure everything is configured ok ?

#9

Updated by vincent auroch over 8 years ago

Juste tested with your new 0.4.1 : no change. Still missing pencils.

Vincent

#10

Updated by Haru Iida over 8 years ago

vincent auroch は書きました:

Juste tested with your new 0.4.1 : no change. Still missing pencils.

Vincent

Thanks.

I have reproduced it.
If your file path has some kind of special characters(ex. "'"), pencil icon does not appear.

I will try to fix it.

#11

Updated by vincent auroch over 8 years ago

I confirm : it works definitely fine with files without special chars.

Thanks for your support

Vincent

#12

Updated by Gergely Szabó over 8 years ago

Haru Iida は書きました:

Hi Gergely Szabó

No, I don't see pencil icons, even if I click (diff) at right side of file name.
Arigato
Gergely

hmm. Can you try my new code?
https://bitbucket.org/haru_iida/redmine_code_review/get/tip.zip

I've made a backup of the database, installed your new code, migrated the database. My Redmine is now dead. Error message:

Ruby on Rails application could not be started
A source file that the application requires, is missing.

    It is possible that you didn't upload your application files correctly. Please check whether all your application files are uploaded.
    A required library may not installed. Please install all libraries that this application requires.

Further information about the error may have been written to the application's log file. Please check it in order to analyse the problem.

Error message:
    no such file to load -- code_review_application_hooks (MissingSourceFile)
Exception class:
    PhusionPassenger::UnknownError
Application root:
    /usr/share/redmine 

#13

Updated by Haru Iida over 8 years ago

  • Status changed from 新規(New) to 解決(Resolved)
  • % Done changed from 0 to 100

更新履歴 commit:c3363e70710e で適用されました。

#14

Updated by Haru Iida over 8 years ago

  • Status changed from 解決(Resolved) to 終了(Closed)

Also available in: Atom PDF