Project

General

Profile

Code Review #420

reek の指摘に従い、リファクタリング

Added by Takashi Takebayashi about 9 years ago. Updated about 9 years ago.

Status:
終了(Closed)
Priority:
通常(Normal)
Target version:
Start date:
06/01/2010
Due date:
% Done:

100%

Estimated time:
1.00 h
Spent time:

Description

test/unit/joel_test_score_test.rb -- 7 warnings:
JoelTestScoreTest#test_is_joel_test_scores_should_equal calls joel_test_scores(:joel_test_scores001) twice (Duplication)
JoelTestScoreTest#test_is_joel_test_scores_should_equal calls joel_test_scores(:joel_test_scores001).user_id twice (Duplication)
JoelTestScoreTest#test_is_joel_test_scores_should_equal calls joel_test_scores(:joel_test_scores003) twice (Duplication)
JoelTestScoreTest#test_is_joel_test_scores_should_equal has approx 7 statements (LongMethod)
JoelTestScoreTest#test_is_joel_test_scores_should_equal has the variable name 'user1' (UncommunicativeName)
JoelTestScoreTest#test_is_joel_test_scores_should_return_not_nil calls joel_test_scores(:joel_test_scores001) twice (Duplication)
JoelTestScoreTest#test_is_joel_test_scores_should_return_not_nil calls joel_test_scores(:joel_test_scores001).user_id twice (Duplication)

Associated revisions

Revision 53:85bc03a5ee05 (diff)
Added by Takashi Takebayashi about 9 years ago

fixes #420
単体テストのリファクタリング

Revision 54:218620151bb2 (diff)
Added by Takashi Takebayashi about 9 years ago

fixes #420
単体テスト等のリファクタリング

Revision 56:4d79c4a4a464 (diff)
Added by Takashi Takebayashi about 9 years ago

fixes #420
単体テスト等のリファクタリング

Revision 64:b9f2284cc366 (diff)
Added by Takashi Takebayashi about 9 years ago

refs #420
単体テストの追加&リファクタリング

Revision 65:d06b12f1a29c (diff)
Added by Takashi Takebayashi about 9 years ago

refs #420
関数と単体テストのリファクタリング

History

#1

Updated by Takashi Takebayashi about 9 years ago

  • Status changed from 担当(Assigned) to 終了(Closed)
  • % Done changed from 0 to 100
  • Estimated time set to 1.00 h

joel_test_score_test.rb に関しては、リファクタリング終了

Also available in: Atom PDF