プロジェクト

全般

プロフィール

Defect #1345

'Add Ticket' button no longer works with Chrome 37+

Jamie Pressほぼ4年前に追加. ほぼ4年前に更新.

ステータス:
終了(Closed)
優先度:
通常(Normal)
対象バージョン:
開始日:
2014/09/06
期日:
進捗率:

100%

予定工数:

説明

Since Chrome 37, the popup window method no longer works. It does still work in IE 11.

The same issue seems to be described here and may provide clues:
http://www.bugdebugzone.com/2014/08/sitecore-modal-pop-ups-are-not-working.html

Love worktime, and hope to have it still work in Chrome!

Thanks.

popup_bug.jpg (73.2 KB) popup_bug.jpg Jamie Press, 2014/09/06 05:38
wt-1345.patch (7.49 KB) wt-1345.patch Olivier Houdas, 2014/09/12 21:36
516

関係しているリビジョン

リビジョン 350:9b04d80abbab (差分)
Tomohisa Kusukawaほぼ4年前に追加

refs #1345 Change to Ajax from a modal dialog (Add Tickets)

リビジョン dc5e1838 (差分)
Tomohisa Kusukawaほぼ4年前に追加

refs #1345 Change to Ajax from a modal dialog (Add Tickets)

リビジョン 351:f432ed187e5b (差分)
Tomohisa Kusukawaほぼ4年前に追加

refs #1345 Change to Ajax from a modal dialog (update done ratio)

リビジョン 2054f3ef (差分)
Tomohisa Kusukawaほぼ4年前に追加

refs #1345 Change to Ajax from a modal dialog (update done ratio)

リビジョン 352:ebafbdda1955 (差分)
Tomohisa Kusukawaほぼ4年前に追加

fixes #1345 Change to Ajax from a modal dialog (relay ticket, etc)

リビジョン 844c527b (差分)
Tomohisa Kusukawaほぼ4年前に追加

fixes #1345 Change to Ajax from a modal dialog (relay ticket, etc)

リビジョン 356:8a1ae343b345 (差分)
Tomohisa Kusukawaほぼ4年前に追加

refs #1345 done ratio should be clickable only at permitted

リビジョン d7493c99 (差分)
Tomohisa Kusukawaほぼ4年前に追加

refs #1345 done ratio should be clickable only at permitted

リビジョン 0432762f
Tomohisa Kusukawaほぼ4年前に追加

fixes #1345 Close branch

履歴

#1 Tomohisa Kusukawaほぼ4年前に更新

  • ステータス新規(New) から 担当(Assigned) に変更
  • 担当者Tomohisa Kusukawa にセット

Thank you for your report.
I will consider how to respond.

#2 Jamie Pressほぼ4年前に更新

Just some updates, as we searched for a workaround.

  1. Firefox 32 (latest) works properly.
  2. IE 11 works sometimes (occasionally opens a blank popup window)

Please note that our test case is ONLY the 'add ticket' button in Worktime.

Thanks.

#3 Olivier Houdasほぼ4年前に更新

The issue is due to Chrome 37 stopping to include showModalDialog() in its javascript engine.
You will find a patch attached with a way to fix the issue. It is not very elegant, as I had to work around the fact that the replacement function is not modal (asynchronous call) and therefore we need to split the functions in 2 : one part before the popup, and a second part executed after.

#4 Tomohisa Kusukawaほぼ4年前に更新

  • ステータス担当(Assigned) から 解決(Resolved) に変更
  • 進捗率0 から 100 に変更

更新履歴 commit:ebafbdda1955 で適用されました。

#5 Tomohisa Kusukawaほぼ4年前に更新

Thank you very much for your report and especially patches.

I was considered variety,
The Ajax was desirable for usability of the future, maybe.

If you are available, please try following alpha version.

mercurial clone
https://tkusukawa@bitbucket.org/tkusukawa/redmine_work_time

download
https://bitbucket.org/tkusukawa/redmine_work_time/downloads
-> Branches tab -> #1345

#6 Olivier Houdasほぼ4年前に更新

It seems to work fine (tested only adding an issue and changing completion percentage). I tested on RM 2.5.2.
By the way, completion percentages are clickable even though Redmine's option is set to follow issues statuses (in that case, changing the value has no effect). It might make sense not to show a link if Issue.use_status_for_done_ratio? is true.

#7 Tomohisa Kusukawaほぼ4年前に更新

Certainly.

I modified at commit:8a1ae34

Thanks again!

#8 Tomohisa Kusukawaほぼ4年前に更新

更新履歴 commit:9ec9d92b7324 で適用されました。

#9 Tomohisa Kusukawaほぼ4年前に更新

  • ステータス解決(Resolved) から 終了(Closed) に変更
  • 対象バージョン0.2.16 にセット

Close branch and merge to default line. (repository)
Thank you.

他の形式にエクスポート: Atom PDF