Project

General

Profile

Proposal #1318

I suggest to show the Set/Delete holiday menu to admins on the global page

Added by Olivier Houdas about 5 years ago. Updated almost 5 years ago.

Status:
終了(Closed)
Priority:
通常(Normal)
Target version:
Start date:
04/15/2014
Due date:
% Done:

100%

Estimated time:

Description

If you select Work time from the top right menu (that is, not linked to any project), the button "set holiday on this date" is not displayed.

I suggest changing app/views/work_time/show.html.erb line 10 from
<%if @project && User.current.allowed_to?(:edit_work_time_total, @project) then%>
to
<%if ((User.current.admin) || (@project && User.current.allowed_to?(:edit_work_time_total, @project))) then%>

so that global admins still get the right to set bank holidays for the all teams without selecting a specific project. This is all the more justified that the holiday table does not store any associated project.

Associated revisions

Revision 312:f87684d3e1bc (diff)
Added by Tomohisa Kusukawa almost 5 years ago

fixes #1318 I suggest to show the Set/Delete holiday menu to admins on the global page

Revision bd305ca5 (diff)
Added by Tomohisa Kusukawa almost 5 years ago

fixes #1318 I suggest to show the Set/Delete holiday menu to admins on the global page

History

#1

Updated by Tomohisa Kusukawa almost 5 years ago

  • Target version set to 0.2.15
#2

Updated by Tomohisa Kusukawa almost 5 years ago

  • Status changed from 新規(New) to 解決(Resolved)
  • % Done changed from 0 to 100

更新履歴 commit:f87684d3e1bc で適用されました。

#3

Updated by Tomohisa Kusukawa almost 5 years ago

  • Status changed from 解決(Resolved) to 終了(Closed)

I released Ver.0.2.15.
http://www.r-labs.org/news/180

Also available in: Atom PDF